[TYPES] [Features] Added creation of JavaScript password to encrypt vendor scripts #3132
+506
−235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added creation of javascript password to encrypt vendor scripts
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for vendor-specific JavaScript password encryption in the ioBroker setup process. The changes enable vendors to provide a JavaScript password in their vendor configuration file (iob-vendor.json), which will be encrypted and stored in the system configuration.
- Added
javascriptPasswordfield to vendor file interface and handling logic - Improved type safety across setup files with better TypeScript typing
- Updated database configuration types to support Redis Sentinel with array types for host and port
- Applied code modernization using nullish coalescing operators and optional chaining
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/types-dev/config.d.ts | Updated DatabaseOptions interface to support Redis Sentinel (arrays for host/port) and made dataDir optional |
| packages/cli/src/lib/setup/setupVendor.ts | Added JavaScript password encryption feature, improved typing with iobVendorFile interface and InternalLogger type |
| packages/cli/src/lib/setup/setupSetup.ts | Enhanced type safety, improved import organization, and updated variable naming consistency |
| CHANGELOG.md | Documented the new JavaScript password encryption feature |
GermanBluefox
changed the title
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
4 tasks
Contributor
|
@GermanBluefox I've opened a new pull request, #3144, to work on those changes. Once the pull request is ready, I'll request review from you. |
…3144) * Initial plan * Remove useless dataDir check in setupSetup.ts The check was reading config and testing if dataDir exists, but then just writing it back without modification. This serves no purpose and has been removed per feedback. Co-authored-by: GermanBluefox <4582016+GermanBluefox@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: GermanBluefox <4582016+GermanBluefox@users.noreply.github.com> Co-authored-by: Bluefox <dogafox@gmail.com>
…racefully stop it to let the jsonl files be written
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added creation of javascript password to encrypt vendor scripts
Vendor wants to encrypt all specific scripts.